Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow secure decorator on statements using imported types #12909

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jan 4, 2024

Resolves #12908

The @secure() decorator is disallowed on statements that refer to type aliases, but the current check is only looking for TypeAliasSymbols and misses imported types.

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew enabled auto-merge (squash) January 4, 2024 16:53
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Test this change out locally with the following install scripts (Action run 7414267674)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7414267674
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7414267674"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7414267674
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7414267674"

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Test Results

    63 files   -     36      63 suites   - 36   25m 17s ⏱️ - 31m 9s
10 470 tests  -     14  10 470 ✅  -     13  0 💤 ±0  0 ❌  - 1 
25 435 runs   - 12 713  25 435 ✅  - 12 712  0 💤 ±0  0 ❌  - 1 

Results for commit fb4a0ab. ± Comparison against base commit 6dfa50e.

@jeskew jeskew merged commit 762fd85 into main Jan 4, 2024
44 checks passed
@jeskew jeskew deleted the jeskew/12908 branch January 4, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants