Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use languageVersion 2.0 when any compile-time imports are present #12902

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jan 3, 2024

Resolves #12899

#12899 highlighted a way in which an imported variable could enclose a user-defined type (and thus necessitate languageVersion 2.0). Since any imported value might require the elevated language version, this PR updates EmitterSettings to use lv 2.0 if any compile-time imports are used.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Test this change out locally with the following install scripts (Action run 7412012579)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7412012579
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7412012579"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7412012579
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7412012579"

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Test Results

    74 files   -    25      74 suites   - 25   28m 57s ⏱️ - 26m 53s
10 466 tests  -    14  10 465 ✅  -    15  0 💤 ±0  1 ❌ +1 
28 318 runs   - 9 818  28 316 ✅  - 9 820  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 8515bd2. ± Comparison against base commit df7406b.

♻️ This comment has been updated with latest results.

@jeskew jeskew enabled auto-merge (squash) January 3, 2024 21:30
@jeskew jeskew requested a review from a team January 3, 2024 21:30
@jeskew jeskew merged commit 6dfa50e into main Jan 4, 2024
43 of 44 checks passed
@jeskew jeskew deleted the jeskew/12899 branch January 4, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants