Allow usage of imports which reference user defined functions in .bicepparam files #12900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 7403460201) VSCode
Azure CLI
|
anthony-c-martin
changed the title
anthony-c-martin
force-pushed
the
ant/issue12799
branch
2 times, most recently
from
ab93666
to
2ec07b8
Compare
jeskew
reviewed
Jan 3, 2024
|
|
||
| return Result.For(DiagnosticBuilder.ForPosition(symbol.DeclaringImportedSymbolsListItem.OriginalSymbolName).ImportedSymbolNotFound(symbol.OriginalSymbolName ?? LanguageConstants.MissingName)); | ||
| TemplateEngine.ProcessTemplateLanguageExpressions(null, null, null, template, TemplateWriter.NestedDeploymentResourceApiVersion, null); |
There was a problem hiding this comment.
[nit]: I think this line could be skipped, since the compiled template will still be queried via a TemplateVariablesEvaluator that evaluates expressions as needed. But it also doesn't do any harm.
There was a problem hiding this comment.
I tried removing this and the scenario test started failing - leaving in for now
jeskew
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12799
Microsoft Reviewers: Open in CodeFlow