Narrow object types when assigned value is not an object literal or variable reference #12798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 7411848343) VSCode
Azure CLI
|
anthony-c-martin
approved these changes
Jan 3, 2024
anthony-c-martin
pushed a commit
that referenced
this pull request
Feb 9, 2024
…s an additional properties type (#13272) Resolves #13247 The type narrowing on objects introduced in #12798 will erroneously raise a missing property diagnostic if the assigned value does not have an explicit property defined for each of the target's required properties, even if the assigned value allows additional properties. This PR updates the type narrowing to consider required properties not to be missing if the assigned value allows arbitrary additional properties. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12590
The TypeValidator's object type narrowing logic currently only runs when the assigned value is or can be traced directly back to an object literal (i.e., an
ObjectSyntaxnode). This PR updates the narrowing logic for both object and discriminated objects to be type- rather than syntax-driven, which allows narrowing to be performed on the return value of expressions, property/array accesses, and references to resources, module outputs, and imported variables.Microsoft Reviewers: Open in CodeFlow