Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to simplify logic for 3rd party provider implementation #12754

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Refactor to simplify logic for 3rd party provider implementation #12754

merged 3 commits into from
Dec 15, 2023

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Dec 14, 2023 •
edited by microsoft-github-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

Test this change out locally with the following install scripts (Action run 7225396899)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7225396899
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7225396899"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7225396899
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7225396899"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

Test Results

       66 files   -        32         66 suites   - 32   28m 48s ⏱️ - 2h 35m 58s
10 425 tests  -        16  10 425 ✔️  -        15  0 💤  - 1  0 ❌ ±0 
25 345 runs   - 12 674  25 345 ✔️  - 12 671  0 💤  - 3  0 ❌ ±0 

Results for commit ed5f331. ± Comparison against base commit fef5764.

♻️ This comment has been updated with latest results.

shenglol
shenglol approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 5c0d0fe into main Dec 15, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthony-c-martin @shenglol