Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write lint sarif output to stdout instead of stderr #12703

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Dec 12, 2023

  • Makes bicep lint command simpler to use with sarif + output redirection (described in Export lint output to file #11960)
  • Simplify the diagnostic logging logic to avoid the need to 'setup' and 'flush' the logger.
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Test this change out locally with the following install scripts (Action run 7183564318)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7183564318
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7183564318"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7183564318
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7183564318"

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Test Results

     132 files  ±0       132 suites  ±0   4h 21m 40s ⏱️ - 3m 37s
10 927 tests ±0  10 927 ✔️ +3  0 💤 ±0  0  - 3 
52 631 runs  ±0  52 631 ✔️ +3  0 💤 ±0  0  - 3 

Results for commit 2447457. ± Comparison against base commit e64dd8c.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Write lint output to stdout instead of stderr Write lint sarif output to stdout instead of stderr Dec 12, 2023
@anthony-c-martin anthony-c-martin enabled auto-merge (squash) December 12, 2023 15:11
@anthony-c-martin anthony-c-martin merged commit 7f3afc5 into main Dec 12, 2023
45 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/exp/lint_stdout branch December 12, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants