Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support overriding of default values when building .bicepparam files #12648

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Support overriding of default values when building .bicepparam files #12648

merged 1 commit into from
Dec 12, 2023

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Dec 7, 2023 •
edited by microsoft-github-policy-service bot
Loading

Closes #12647

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

Test this change out locally with the following install scripts (Action run 7180246515)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7180246515
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7180246515"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7180246515
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7180246515"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

Test Results

     143 files  +     13       143 suites  +13   5h 26m 49s ⏱️ + 1h 5m 41s
10 925 tests +       2  10 923 ✔️ ±       0  0 💤 ±0  2 ❌ +2 
54 753 runs  +2 138  54 751 ✔️ +2 136  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit f7f7f75. ± Comparison against base commit 7e89b5a.

♻️ This comment has been updated with latest results.

shenglol
shenglol approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit e64dd8c into main Dec 12, 2023
46 of 47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue12647 branch December 12, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bicepparam inline overrides don't work when defaulting in bicep file instead of bicepparam file
2 participants
@anthony-c-martin @shenglol