Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove userDefinedTypes from feature config #12577

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Nov 27, 2023

Resolves #12576

The userDefinedTypes property of experimentalFeaturesEnabled in bicepconfig.json hasn't had any effect for several releases, but VS Code will still offer completions for it because it's declared in the file's schema.

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew enabled auto-merge (squash) November 27, 2023 16:35
@jeskew jeskew requested a review from a team November 27, 2023 16:35
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Test this change out locally with the following install scripts (Action run 7009220994)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7009220994
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7009220994"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7009220994
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7009220994"

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up!

@jeskew jeskew disabled auto-merge November 27, 2023 16:51
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Test Results

     154 files  +     23       154 suites  +23   5h 40m 12s ⏱️ + 47m 56s
10 845 tests ±       0  10 843 ✔️  -        1  0 💤 ±0  2 +1 
57 292 runs  +5 102  57 290 ✔️ +5 101  0 💤 ±0  2 +1 

For more details on these failures, see this check.

Results for commit 983d61e. ± Comparison against base commit 5c2e287.

♻️ This comment has been updated with latest results.

@jeskew jeskew merged commit 92ff84d into main Nov 27, 2023
46 of 47 checks passed
@jeskew jeskew deleted the jeskew/prune-experimental-features-config branch November 27, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove userDefinedTypes from experimentalFeaturesEnabled in bicepconfig.json
2 participants