Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use discriminator constraint to declare tagged union types when loading ARM JSON models #12388

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Nov 6, 2023

Resolves #12331

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Test this change out locally with the following install scripts (Action run 6849987668)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6849987668
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6849987668"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6849987668
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6849987668"

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Test Results

     132 files  ±0       132 suites  ±0   4h 50m 0s ⏱️ - 3m 43s
10 684 tests +1  10 684 ✔️ +1  0 💤 ±0  0 ±0 
51 631 runs  +4  51 631 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit 86a405b. ± Comparison against base commit 25b94b2.

@jeskew jeskew marked this pull request as ready for review November 6, 2023 16:22
@jeskew jeskew requested a review from a team November 6, 2023 16:22
@jeskew jeskew merged commit 2bbec90 into main Nov 13, 2023
47 checks passed
@jeskew jeskew deleted the jeskew/load-tagged-unions-from-ARM-models branch November 13, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-Defined Types - Compiled JSON does not recognize discriminator types
2 participants