Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSBuild support for .bicepparam #12272

Merged
merged 3 commits into from
Oct 25, 2023
Merged

MSBuild support for .bicepparam #12272

merged 3 commits into from
Oct 25, 2023

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Oct 25, 2023 •
edited
Loading

Microsoft Reviewers: Open in CodeFlow

Closes #12124

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

Test this change out locally with the following install scripts (Action run 6646134901)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6646134901
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6646134901"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6646134901
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6646134901"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

Test Results

     132 files  ±  0       132 suites  ±0   4h 14m 49s ⏱️ + 24m 52s
10 678 tests +  9  10 678 ✔️ +  9  0 💤 ±0  0 ❌ ±0 
51 599 runs  +36  51 599 ✔️ +36  0 💤 ±0  0 ❌ ±0 

Results for commit 4c8dbf8. ± Comparison against base commit b1c243d.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title WIP: MSBuild support for .bicepparam MSBuild support for .bicepparam Oct 25, 2023
@anthony-c-martin anthony-c-martin marked this pull request as ready for review October 25, 2023 14:59
majastrz
majastrz approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 914ac3a into main Oct 25, 2023
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/bicepparams-msbuild branch October 25, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bicep MSBuild task doesn't support BicepParams
2 participants
@anthony-c-martin @majastrz