Allow declaring decorators on nested child resources #12209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenglol
reviewed
Oct 20, 2023
shenglol
reviewed
Oct 20, 2023
| resource sqlDatabase 'databases' = [for db in dbs: { | ||
| name: db | ||
| location: 'polandcentral' | ||
| }] |
There was a problem hiding this comment.
Can we add some negative test cases to ensure other declaration types are blocked?
There was a problem hiding this comment.
Sure, will do that tomorrow.
There was a problem hiding this comment.
I added negative tests. I also needed to add visiting MissingDeclarationSyntaxes in the TypeAssignmentVisitor to emit appropriate diagnostics
miqm
changed the title
|
Test this change out locally with the following install scripts (Action run 6631343793) VSCode
Azure CLI
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10970
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Contributing a feature
Microsoft Reviewers: Open in CodeFlow