Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct terminating token for tuple parsing recovery #12140

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Oct 13, 2023

Resolves #12126

The terminating tokens passed to WithRecovery when parsing tuple type members were '\n' and '}' instead of '\n' and ']' (likely due to a copy/paste error).

This would cause the parser to hang when it encountered a '}' in a position where the parser expected a standalone type expression, as the parser would neither be able to parse the '}' nor advance past it in https://github.com/Azure/bicep/blob/main/src/Bicep.Core/Parsing/BaseParser.cs#L1259-L1270

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested a review from a team October 13, 2023 17:19
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Test this change out locally with the following install scripts (Action run 6511896128)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6511896128
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6511896128"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6511896128
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6511896128"

@jeskew jeskew enabled auto-merge (squash) October 13, 2023 17:26
@github-actions
Copy link
Contributor

Test Results

     132 files  ±0       132 suites  ±0   3h 53m 36s ⏱️ + 10m 39s
10 669 tests +1  10 668 ✔️ +1  0 💤 ±0  1 ±0 
51 563 runs  +4  51 562 ✔️ +4  0 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit b5a2177. ± Comparison against base commit 48a96c1.

@jeskew jeskew merged commit 20067dc into main Oct 13, 2023
46 of 47 checks passed
@jeskew jeskew deleted the jeskew/12126 branch October 13, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Defined Type formatting can cause memory consumption issue
2 participants