Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--with-source argument for publish command #12128

Merged
merged 3 commits into from
Oct 23, 2023
Merged

--with-source argument for publish command #12128

merged 3 commits into from
Oct 23, 2023

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Oct 12, 2023 •
edited
Loading

Fixes #12113
Until experimental flag is removed, flag must be enabled and also --with-publish must be specified to publish source.

Microsoft Reviewers: Open in CodeFlow

@StephenWeatherford StephenWeatherford changed the title --with-source argument for publish --with-source argument for publish command Oct 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

Test this change out locally with the following install scripts (Action run 6616154091)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6616154091
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6616154091"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6616154091
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6616154091"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

Test Results

     132 files  ±    0       132 suites  ±0   3h 41m 22s ⏱️ - 1m 35s
10 639 tests  -   29  10 639 ✔️  -   28  0 💤 ±0  0 ❌  - 1 
51 443 runs   - 116  51 443 ✔️  - 115  0 💤 ±0  0 ❌  - 1 

Results for commit 98ecfc3. ± Comparison against base commit 48a96c1.

♻️ This comment has been updated with latest results.

shenglol
shenglol approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo. Otherwise looks good!

@StephenWeatherford StephenWeatherford merged commit ec3e375 into main Oct 23, 2023
47 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/cli-withsource branch October 23, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

@asilverman asilverman Awaiting requested review from asilverman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish source: Add --with-source to publish command
2 participants
@StephenWeatherford @shenglol