Update CyclicCheckVisitor to prohibit self references within an access expression in type syntax #12072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12070
CyclicTypeVisitor
permits cycles within type expressions to allow for recursive type definitions. However, this can cause an unhandled stack overflow when a property or array access expression is within a "type container expression" (e.g.,ObjectTypePropertySyntax
), since access expressions will try to resolve the type of their base expression. For example:Microsoft Reviewers: Open in CodeFlow