Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExpressionRewriteVisitor to rewrite param and output type clauses #12055

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Oct 5, 2023

Resolves #12052

A recent PR (#12048) updated TemplateWriter to preprocess a template's references to imported symbols. This new step uses an ExpressionRewriteVisitor, which had not been kept up to date when new properties were added various kinds of IR expressions.

The PR also adds a few more lines to the Imports_LF baseline scenario to exercise additional behavior. The scenario had originally been written to validate the mechanics of importing types and variables but didn't cover the mechanics of using imported symbols in a template.

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested a review from a team October 5, 2023 16:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Test this change out locally with the following install scripts (Action run 6426922109)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6426922109
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6426922109"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6426922109
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6426922109"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Test Results

     132 files  ±0       132 suites  ±0   3h 47m 18s ⏱️ - 12m 25s
10 668 tests +1  10 668 ✔️ +1  0 💤 ±0  0 ±0 
51 539 runs  +4  51 539 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit 3a4cb0f. ± Comparison against base commit d7b6beb.

♻️ This comment has been updated with latest results.

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeskew jeskew merged commit 5684992 into main Oct 6, 2023
47 checks passed
@jeskew jeskew deleted the jeskew/12052 branch October 6, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using a parameter with an imported user-defined type array, template compilation fails
2 participants