Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeFix: Remove relative path prefix from types loading #12026

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

asilverman
Copy link
Contributor

@asilverman asilverman commented Oct 2, 2023

Description

The current implementation makes the wrong assumption that the key names indexed in the types cache have a prefix ./. This was the case when I was using a dev artifact since the publishing logic wasn't ready.

Now that we have a publishing logic for the types package we can fix the code so that it doesn't assume the ./ prefix is found in the files as proven by https://github.com/Azure/bicep-types-az/actions/runs/6398352791/job/17368317634.

This PR should be merged before Azure/bicep-types-az#1553, and Azure/bicep-types-az#1553 should be updated to download the latest build from the main branch.

Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Test this change out locally with the following install scripts (Action run 6410903581)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6410903581
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6410903581"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6410903581
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6410903581"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Test Results

     132 files  ±  0       132 suites  ±0   3h 52m 47s ⏱️ + 4m 58s
10 665 tests +10  10 665 ✔️ +10  0 💤 ±0  0 ±0 
51 527 runs  +40  51 527 ✔️ +40  0 💤 ±0  0 ±0 

Results for commit 2905138. ± Comparison against base commit 61badcd.

♻️ This comment has been updated with latest results.

@asilverman asilverman marked this pull request as ready for review October 3, 2023 21:09
@asilverman asilverman added the story: dynamic type loading Collects all work items related to decoupling of Bicep types from compiler label Oct 3, 2023
@asilverman asilverman self-assigned this Oct 3, 2023
@asilverman asilverman modified the milestones: v0.22, v0.23 Oct 3, 2023
@asilverman asilverman enabled auto-merge (squash) October 4, 2023 00:16
@asilverman asilverman requested a review from jeskew October 4, 2023 16:41
.vscode/launch.json Outdated Show resolved Hide resolved
@asilverman asilverman requested a review from jeskew October 4, 2023 16:49
auto-merge was automatically disabled October 4, 2023 17:20

Base branch was modified

@asilverman asilverman merged commit d62b94d into main Oct 4, 2023
47 checks passed
@asilverman asilverman deleted the asilverman/fix-type-loading-logic branch October 4, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story: dynamic type loading Collects all work items related to decoupling of Bicep types from compiler
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants