Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undoing validate-params command PR #11974

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Undoing validate-params command PR #11974

merged 6 commits into from
Oct 2, 2023

Conversation

Usman0111
Copy link
Contributor

@Usman0111 Usman0111 commented Sep 28, 2023 •
edited by microsoft-github-policy-service bot
Loading

Undoing work for validate-params command since we have decided to switch to validating inline params through build-params command

Microsoft Reviewers: Open in CodeFlow

@Usman0111 Usman0111 changed the title Usman0111/undo validate params Undoing validate-params command PR Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

Test this change out locally with the following install scripts (Action run 6383489955)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6383489955
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6383489955"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6383489955
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6383489955"

@Usman0111 Usman0111 enabled auto-merge (squash) September 28, 2023 16:23
@github-actions
Copy link
Contributor

Test Results

     132 files   -      11       132 suites   - 11   3h 25m 4s ⏱️ - 16m 1s
10 654 tests  -        3  10 654 ✔️  -        3  0 💤 ±0  0 ❌ ±0 
51 483 runs   - 2 850  51 483 ✔️  - 2 850  0 💤 ±0  0 ❌ ±0 

Results for commit f440e5c. ± Comparison against base commit 6f58518.

anthony-c-martin
anthony-c-martin approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please confirm there are no AzCLI or AzPwsh dependencies on this command before merging.

@Usman0111 Usman0111 merged commit c43ca5f into main Oct 2, 2023
47 checks passed
@Usman0111 Usman0111 deleted the Usman0111/undo-validate-params branch October 2, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
story: bicep parameters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Usman0111 @anthony-c-martin