Fix nested type property decorator completions #11972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11970
The LS is currently looking at the type of the top-level statement in which a cursor is located when proposing decorator completions. This means that for a scenario like the following:
the LS will propose completions for decorators that can be used on objects (the type of the full
type obj = {...}
statement) rather than decorators that can be used on integers (the type of the decorator's target). Consequently, the LS is proposing completions that will raise an error diagnostic (like@sealed()
or@discriminator()
) and not proposing completions that would be valid (like@minValue()
).Microsoft Reviewers: Open in CodeFlow