Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Pane: support tenant & mg scope deployments #11917

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Sep 23, 2023

  • Support tenant & management group scoped deployments
  • Allow collapsing/expanding of form sections
  • Various styling tweaks

Closes #11529
Closes #11566

Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2023

Test this change out locally with the following install scripts (Action run 6301869901)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6301869901
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6301869901"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6301869901
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6301869901"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2023

Test Results

     132 files  ±0       132 suites  ±0   3h 36m 54s ⏱️ + 11m 50s
10 553 tests ±0  10 553 ✔️ ±0  0 💤 ±0  0 ±0 
50 763 runs  ±0  50 763 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a6ce883. ± Comparison against base commit 61b423c.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) September 23, 2023 14:25
@Usman0111
Copy link
Contributor

I know this is experimental right now but should we find a way to test changes on the extension side?

Copy link
Contributor

@Usman0111 Usman0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@anthony-c-martin anthony-c-martin merged commit 1abffea into main Sep 25, 2023
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/more_scopes branch September 25, 2023 16:01
@anthony-c-martin
Copy link
Member Author

I know this is experimental right now but should we find a way to test changes on the extension side?

I'm considering this a pre-requisite to making this non-experimental - testing is just complex because of the service dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants