Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implicit nullability to optional module params #11887

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Sep 19, 2023

Partially addresses #11883

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested a review from a team September 19, 2023 16:19
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Test this change out locally with the following install scripts (Action run 6239866134)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6239866134
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6239866134"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6239866134
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6239866134"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Test Results

     132 files  ±0       132 suites  ±0   3h 22m 48s ⏱️ + 7m 15s
10 540 tests +1  10 540 ✔️ +1  0 💤 ±0  0 ±0 
50 711 runs  +4  50 711 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit 5bcf726. ± Comparison against base commit 547c9c4.

♻️ This comment has been updated with latest results.

@jeskew jeskew force-pushed the jeskew/add-implicit-null-on-optional-params branch from 82f444e to 5bcf726 Compare September 19, 2023 17:47
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeskew jeskew enabled auto-merge (squash) September 19, 2023 18:26
@jeskew jeskew merged commit 7524201 into main Sep 19, 2023
47 checks passed
@jeskew jeskew deleted the jeskew/add-implicit-null-on-optional-params branch September 19, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants