Use languageVersion 2.0 if any types are imported

[jeskew]

Resolves #11881

Bicep will use languageVersion: 2.0 in compiled templates if the source template contains any type statements or uses type expressions that will result in ARM syntax only supported in language version 2.0. The compiler needs to also check if there were any import statements that pull in user-defined types, as that will also result in a template with syntax requiring language version 2.0.

Microsoft Reviewers: Open in CodeFlow

[github-actions]

Test this change out locally with the following install scripts (Action run 6239527020)

VSCode

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6239527020

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6239527020"

Azure CLI

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6239527020

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6239527020"

[github-actions]

Test Results

     132 files  ±0       132 suites  ±0   3h 36m 44s ⏱️ + 21m 11s
10 541 tests +2  10 541 ✔️ +2  0 💤 ±0  0 ❌ ±0 
50 715 runs  +8  50 715 ✔️ +8  0 💤 ±0  0 ❌ ±0 

Results for commit a3e777c. ± Comparison against base commit 547c9c4.

♻️ This comment has been updated with latest results.

[majastrz]

                    syntax is NullableTypeSyntax,

Out of scope of the PR, but should we have an interface or a base type to indicate that the syntax node declares a user defined type? We use that approach in other places with symbols or even some syntax nodes to easily discover that something is an expression node and such.

---

Refers to: src/Bicep.Core/Emit/EmitterSettings.cs:36 in a3e777c. [](commit_id = a3e777c, deletion_comment = False)

[majastrz]

[jeskew]

                    syntax is NullableTypeSyntax,

Out of scope of the PR, but should we have an interface or a base type to indicate that the syntax node declares a user defined type? We use that approach in other places with symbols or even some syntax nodes to easily discover that something is an expression node and such.

Refers to: src/Bicep.Core/Emit/EmitterSettings.cs:36 in a3e777c. [](commit_id = a3e777c, deletion_comment = False)

I like that idea. There is a TypeSyntax base class that all of syntax types checked for here extend, but checking for that would also catch resource-typed params and outputs. I can add an IArmTypeConstrainingExpression interface (open to suggestions on the name).