Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block nested deployment resources with inner scoped evaluation and symbolic references to outer scope #11884

Merged
merged 8 commits into from
Sep 22, 2023
Merged

Block nested deployment resources with inner scoped evaluation and symbolic references to outer scope #11884

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8b41647
Block nested deployment resources with inner scoped evaluation and sy…
jeskew Sep 19, 2023
5fd7c00
Update SecureParamsInNestedDeploymentsRule to track implicit inner sc…
jeskew Sep 19, 2023
83667bb
Merge branch 'main' into jeskew/emit-diagnostic-on-outer-scoped-ref-f…
jeskew Sep 19, 2023
ee9112c
Skip check on malformed resource declaration
jeskew Sep 22, 2023
c28e692
Make nested template scoping check a linter rule
jeskew Sep 22, 2023
72cc666
Remove added diagnostic builder
jeskew Sep 22, 2023
7a59e87
Merge branch 'main' into jeskew/emit-diagnostic-on-outer-scoped-ref-f…
jeskew Sep 22, 2023
995d0fa
Reconcile added test with recent changes to `main`
jeskew Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip check on malformed resource declaration
  • Loading branch information
@jeskew
jeskew committed Sep 22, 2023
commit ee9112cf05ee6ae61994a68231aea2e5399fbc18
2 changes: 1 addition & 1 deletion src/Bicep.Core/Emit/EmitLimitationCalculator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ private static void BlockSymbolicReferencesInInnerScopedNestedDeployments(Semant
foreach (var resource in model.DeclaredResources.Where(r => r.IsAzResource))
{
if (!LanguageConstants.ResourceTypeComparer.Equals(resource.TypeReference.FormatType(), AzResourceTypeProvider.ResourceTypeDeployments) ||
resource.Symbol.DeclaringResource.GetBody().TryGetPropertyByName("properties", StringComparison.OrdinalIgnoreCase)?.Value is not ObjectSyntax propertiesObject ||
resource.Symbol.DeclaringResource.TryGetBody()?.TryGetPropertyByName("properties", StringComparison.OrdinalIgnoreCase)?.Value is not ObjectSyntax propertiesObject ||
propertiesObject.TryGetPropertyByName("template", StringComparison.OrdinalIgnoreCase)?.Value is not SyntaxBase nestedTemplate)
{
continue;
Expand Down
Loading