Decompile Bicepparams: Use consistent URI -> FS conversion #11834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Uri outputUri = PathHelper.FilePathToFileUrl(outputPath); | ||
| var inputUri = PathHelper.FilePathToFileUrl(inputPath); | ||
| var outputUri = PathHelper.FilePathToFileUrl(outputPath); | ||
| var bicepUri = bicepPath is {} ? PathHelper.FilePathToFileUrl(bicepPath) : null; |
There was a problem hiding this comment.
Should we be validating this file actually exists?
anthony-c-martin
force-pushed
the
ant/bicepparam_uri
branch
from
3de042d
to
0e7cca5
Compare
anthony-c-martin
force-pushed
the
ant/bicepparam_uri
branch
from
0e7cca5
to
00f78ba
Compare
|
Test this change out locally with the following install scripts (Action run 6263642657) VSCode
Azure CLI
|
jeskew
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we're inconsistent in usage of URI vs file system paths in the language server - this PR fixes that.
This might address #11615, but I'm not confident we have enough information about it to confirm or deny that.
Microsoft Reviewers: Open in CodeFlow