Fix for issue 10343

src/Bicep.Core.IntegrationTests/ScenarioTests.cs

@@ -4987,4 +4987,30 @@ public void Test_Issue502()
 
  result.ExcludingLinterDiagnostics().Should().NotHaveAnyDiagnostics();
  }
+
+ // https://github.com/Azure/bicep/issues/10343
+ [TestMethod]
+ public void Test_Issue10343()
+ {
+ var result = CompilationHelper.Compile(Services.WithFeatureOverrides(new(SymbolicNameCodegenEnabled: true)), ("main.bicep", @"
+resource foo1 'Microsoft.Storage/storageAccounts@2022-09-01' = {
+ name: 'foo'
+}
+
+resource foo2 'Microsoft.Authorization/roleAssignments@2022-04-01' existing = {
+ scope: foo1
+ name: 'blah'
+}
+
+resource foo3 'Microsoft.Storage/storageAccounts@2022-09-01' = {
+ name: 'foo3'
+ properties: {
+ accessTier: foo2.id
+ }
+}
+"));
+
+ var evaluated = TemplateEvaluator.Evaluate(result.Template);
+ evaluated.Should().HaveValueAtPath("resources.foo3.dependsOn", new JArray("foo2"));
+ }
 }

src/Bicep.Core/Emit/EmitterContext.cs

@@ -17,7 +17,7 @@ public EmitterContext(SemanticModel semanticModel)
  SemanticModel = semanticModel;
  DataFlowAnalyzer = new(semanticModel);
  VariablesToInline = InlineDependencyVisitor.GetVariablesToInline(semanticModel);
- ResourceDependencies = ResourceDependencyVisitor.GetResourceDependencies(semanticModel);
+ ResourceDependencies = ResourceDependencyVisitor.GetResourceDependencies(semanticModel, new() { IncludeExisting = Settings.EnableSymbolicNames });
  FunctionVariables = FunctionVariableGeneratorVisitor.GetFunctionVariables(semanticModel);
  }
 

src/Bicep.Core/Emit/ResourceDependencyVisitor.cs

@@ -71,7 +71,7 @@ int GetIndexOfAncestor(ImmutableArray<ResourceAncestorGraph.ResourceAncestor> an
  {
  for (int i = ancestors.Length - 1; i >= 0; i--)
  {
- if (!ancestors[i].Resource.IsExistingResource || (options?.IncludeExisting ?? false))
+ if (!ancestors[i].Resource.IsExistingResource || options?.IncludeExisting == true)
  {
  // we found the non-existing resource - we're done
  return i;
@@ -177,7 +177,7 @@ public override void VisitVariableAccessSyntax(VariableAccessSyntax syntax)
  return;
 
  case ResourceSymbol resourceSymbol:
- if (resourceSymbol.DeclaringResource.IsExistingResource())
+ if (resourceSymbol.DeclaringResource.IsExistingResource() && options?.IncludeExisting != true)
  {
  var existingDependencies = GetResourceDependencies(resourceSymbol);
 

src/Bicep.Core/Intermediate/ExpressionBuilder.cs

@@ -1057,7 +1057,7 @@ private static SyntaxBase GetModuleNameSyntax(ModuleSymbol moduleSymbol)
  return null;
  }
 
- private static bool ShouldGenerateDependsOn(ResourceDependency dependency)
+ private bool ShouldGenerateDependsOn(ResourceDependency dependency)
  {
  if (dependency.Kind == ResourceDependencyKind.Transitive)
  {
@@ -1066,8 +1066,9 @@ private static bool ShouldGenerateDependsOn(ResourceDependency dependency)
  }
 
  return dependency.Resource switch
- { // We only want to add a 'dependsOn' for resources being deployed in this file.
- ResourceSymbol resource => !resource.DeclaringResource.IsExistingResource(),
+ {
+ // 'existing' resources are only represented in the JSON if using symbolic names.
+ ResourceSymbol resource => Context.Settings.EnableSymbolicNames || !resource.DeclaringResource.IsExistingResource(),
  ModuleSymbol => true,
  _ => throw new InvalidOperationException($"Found dependency '{dependency.Resource.Name}' of unexpected type {dependency.GetType()}"),
  };