Remove UserDefinedTypes feature flag #11461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-defined type syntax (or with symbolicNameCodegen enabled)
jeskew
commented
Aug 6, 2023
|
|
||
| // malformed type but type check should still happen | ||
| param malformedType2 44 = f | ||
| //@[06:020) [no-unused-params (Warning)] Parameter "malformedType2" is declared but never used. (CodeDescription: bicep core(https://aka.ms/bicep/linter/no-unused-params)) |malformedType2| | ||
| //@[21:023) [BCP283 (Error)] Using a literal value as a type requires enabling EXPERIMENTAL feature "UserDefinedTypes". (CodeDescription: none) |44| | ||
| //@[26:027) [BCP057 (Error)] The name "f" does not exist in the current context. (CodeDescription: none) |f| |
There was a problem hiding this comment.
I was a bit surprised that this diagnostic hadn't been surfaced in the previous baseline version, but apparently param default values are not validated if there is an error encountered in the param type clause
src/Bicep.Cli/CliResources.resx
Outdated
| @@ -147,4 +141,8 @@ | |||
| <value>The specified input "{0}" was not recognized as a Bicep or Bicep Parameters file. Valid files must either the .bicep or .bicepparam extension.</value> | |||
| <comment>{0} input file path</comment> | |||
| </data> | |||
| <data name="ExperimentalFeaturesDisclaimerMessage" xml:space="preserve"> | |||
| <value>ntal Bicep features have been enabled: {0}. Experimental features should be enabled for testing purposes only. Do not enable these settings for any production usage, or you may be unexpectedly broken at any time!</value> | |||
anthony-c-martin
approved these changes
Aug 10, 2023
StephenWeatherford
pushed a commit
that referenced
this pull request
Aug 11, 2023
Resolves #4158 This PR also updates the TemplateWriter to target a non-experimental ARM languageVersion that allows type definitions (2.0). Templates using experimental ARM features (e.g., extensibility and asserts) now target the 2.1-experimental language version. The languageVersion change entailed a large number of baseline changes. These are included in this PR in a separate commit, and I'll go through and flag any unexpected baseline change. codeflow:open?pullrequest=https://github.com/Azure/bicep/pull/11461&drop=dogfoodAlpha
StephenWeatherford
pushed a commit
that referenced
this pull request
Aug 11, 2023
Resolves #4158 This PR also updates the TemplateWriter to target a non-experimental ARM languageVersion that allows type definitions (2.0). Templates using experimental ARM features (e.g., extensibility and asserts) now target the 2.1-experimental language version. The languageVersion change entailed a large number of baseline changes. These are included in this PR in a separate commit, and I'll go through and flag any unexpected baseline change. codeflow:open?pullrequest=https://github.com/Azure/bicep/pull/11461&drop=dogfoodAlpha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4158
This PR also updates the TemplateWriter to target a non-experimental ARM languageVersion that allows type definitions (2.0). Templates using experimental ARM features (e.g., extensibility and asserts) now target the 2.1-experimental language version.
The languageVersion change entailed a large number of baseline changes. These are included in this PR in a separate commit, and I'll go through and flag any unexpected baseline change.
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/Azure/bicep/pull/11461&drop=dogfoodAlpha