Fixed functions signatures in vararg functions #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
- Coverage 94.24% 94.22% -0.03%
==========================================
Files 328 329 +1
Lines 15866 15904 +38
Branches 14 14
==========================================
+ Hits 14953 14985 +32
- Misses 913 919 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed function signatures reported in error messages for functions that allow a variable number of arguments.
We didn't have good coverage for this, so the first commit adds a set of tests to assert on various properties of function overloads in default namespaces. The second commit fixes the bug. The third commit revises the format of the signature because the original broken one was confusing.