Ignore property storageAccountSubscriptionId for use-resource-id-func… #11094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeskew
approved these changes
Jun 30, 2023
| @@ -52,7 +52,7 @@ public Exclusion(string? regexResourceType, string? propertyName) | |||
| // Some of the names are unique enough (and for backwards compat with the ARM TTK) that we won't worry about matching against | |||
| // an exact resource type, plus some of them occur in multiple resource types. | |||
|
|
|||
| // Both resource type and property name are case-insensitive | |||
| // Resource type is a regex pattern (case-insensitive), property name is an exact match (case-insensitive) | |||
There was a problem hiding this comment.
Are property names only checked for exact matches for performance reasons or to avoid false positives?
There was a problem hiding this comment.
For performance and regex didn't seem to be needed. I considered adding RegEx with this PR but figured I'd wait for now.
davidcho23
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11051
Microsoft Reviewers: Open in CodeFlow