Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter v2 part 8: Make ternary operators and lambdas less newline sensitive #11052

Merged
merged 8 commits into from
Jun 27, 2023
Merged

Formatter v2 part 8: Make ternary operators and lambdas less newline sensitive #11052

merged 8 commits into from
Jun 27, 2023

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Jun 23, 2023 •
edited by ghost
Loading

Closes #5829.

Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

Test Results (linux-x64)

       33 files  ±0         33 suites  ±0   31m 34s ⏱️ + 1m 54s
10 080 tests ±0  10 080 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
12 296 runs  ±0  12 296 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e463123. ± Comparison against base commit f8da7da.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

Test Results (osx-x64)

       33 files  ±0         33 suites  ±0   1h 31m 19s ⏱️ + 6m 32s
10 084 tests ±0  10 084 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
12 300 runs  ±0  12 300 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e463123. ± Comparison against base commit f8da7da.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

Test Results (win-x64)

       33 files  ±0         33 suites  ±0   40m 23s ⏱️ + 7m 22s
10 092 tests ±0  10 092 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
12 307 runs  ±0  12 307 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e463123. ± Comparison against base commit f8da7da.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

Test Results (linux-musl-x64)

       33 files  ±0         33 suites  ±0   33m 37s ⏱️ +25s
10 080 tests ±0  10 080 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
12 296 runs  ±0  12 296 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e463123. ± Comparison against base commit f8da7da.

♻️ This comment has been updated with latest results.

jeskew
jeskew reviewed Jun 26, 2023
View reviewed changes
scripts/SetBaseline.ps1 Outdated Show resolved Hide resolved
@shenglol shenglol merged commit 3ed26c6 into main Jun 27, 2023
52 checks passed
@shenglol shenglol deleted the shenglol/less-newline-sensitivity-2nd-iterataion branch June 27, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeskew jeskew jeskew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permit newline breaks in ternary (a ? b : c), for and if statements
2 participants
@shenglol @jeskew