MAINT: Use dotnet-coverage instead of Coverlet for coverage collection #10809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asilverman
force-pushed
the
asilverman/code-coverage
branch
from
4f3c7c2
to
8139e08
Compare
majastrz
reviewed
May 24, 2023
|
This is a good find btw! |
majastrz
reviewed
May 25, 2023
| @@ -532,7 +532,7 @@ jobs: | |||
| uses: actions/setup-dotnet@v3 | |||
|
|
|||
| - name: Run Tests | |||
| run: dotnet test --filter '${{ matrix.config.filter}}' --configuration release --logger trx --blame --collect:"XPlat Code Coverage" --settings ./.github/workflows/codecov.runsettings --results-directory ./TestResults/ | |||
There was a problem hiding this comment.
Never mind. I see it in the run settings file.
majastrz
reviewed
May 25, 2023
| @@ -532,7 +532,7 @@ jobs: | |||
| uses: actions/setup-dotnet@v3 | |||
|
|
|||
| - name: Run Tests | |||
| run: dotnet test --filter '${{ matrix.config.filter}}' --configuration release --logger trx --blame --collect:"XPlat Code Coverage" --settings ./.github/workflows/codecov.runsettings --results-directory ./TestResults/ | |||
There was a problem hiding this comment.
Never mind. I see the logger settings in runsettings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3 years back, Coverlet was only xplat solution available for .NET and that is why it's such popular. VS Code Coverage solution was only available for Windows. Things have changed since. Today the VS Code Coverage solution is more reliable and considerably faster, it offers static or dynamic instrumentation and unlike Coverlet it supports native C++.
There is a Code Coverage window in which you can run code coverage and display results is only available in VS Ent SKU, however, you can collect coverage in command line scenarios and it's also used in Azure pipelines.
Now it's also offered as .NET global tool and it allows you to export results into various format such as popular Cobertura.
PR Changes:
.github\workflows\codecov.runsettingsto use the VS Code Coverage tool to increase speed and enhance coverage collection.github\workflows\codecov.runsettingsthat were previously passed to thedotnet testcommand as command line arguments so that we have more readable pipelinesMicrosoft Reviewers: Open in CodeFlow