Warn on output values that contain nested secrets #10669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntain nested secrets
…nStack emptiness check
|
@jeskew Might not get to this until next week. |
davidcho23
reviewed
May 12, 2023
src/Bicep.Core/Analyzers/Linter/Rules/OutputsShouldNotContainSecretsRule.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Analyzers/Linter/Rules/OutputsShouldNotContainSecretsRule.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core.Samples/Files/InvalidTypeDeclarations_LF/main.diagnostics.bicep
Show resolved
Hide resolved
|
@jeskew Is there anything in the docs that will need to change? https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/linter-rule-secure-secrets-in-parameters If so, please enter a new bug for that. |
|
@jeskew Thanks for handling this! Gave it a quick look, will try to finish tomorrow. |
src/Bicep.Core/Analyzers/Linter/Rules/OutputsShouldNotContainSecretsRule.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Analyzers/Linter/Rules/OutputsShouldNotContainSecretsRule.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Analyzers/Linter/Rules/OutputsShouldNotContainSecretsRule.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Analyzers/Linter/Rules/OutputsShouldNotContainSecretsRule.cs
Show resolved
Hide resolved
src/Bicep.Core/Analyzers/Linter/Rules/OutputsShouldNotContainSecretsRule.cs
Outdated
Show resolved
Hide resolved
StephenWeatherford
requested changes
May 31, 2023
src/Bicep.Core.UnitTests/Diagnostics/LinterRuleTests/OutputsShouldNotContainSecretsRuleTests.cs
Show resolved
Hide resolved
|
@StephenWeatherford would you mind taking another look when you get a chance? |
StephenWeatherford
approved these changes
Jun 27, 2023
jeskew
added a commit
that referenced
this pull request
Jun 27, 2023
Merging #10669 broke the build on `main` due to a change to an unrelated part of the code since when the PR was checked in CI. This PR fixes the compilation errors that resulted from merging the PR. ###### Microsoft Reviewers: [Open in CodeFlow](https://portal.fabricbot.ms/api/codeflow?pullrequest=https://github.com/Azure/bicep/pull/11084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10676 and resolves #10327
This PR updates the
OutputsShouldNotContainSecretsRuleanalyzer rule to warn if an expression used inside an output value contains secrets. This analysis is performed based on the declared type of the value supplied.Microsoft Reviewers: Open in CodeFlow