Add support for Custom Kubernetes Resources #10598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| namespace: 'default' | ||
| kubeConfig: '' | ||
| } | ||
| resource crd 'custom/Foo@v1' = { |
There was a problem hiding this comment.
How do we distinguish whether the user intended to use a Kubernetes fallback type vs an ARM fallback type?
There was a problem hiding this comment.
In that case users have to fully qualify the resource type. Added a test for that: https://github.com/Azure/bicep/pull/10598/files#diff-d3b11a4daaf2569ef3d245e9d62d1745ebf0cadc68056635554f3c19ca911f69R364
anthony-c-martin
approved these changes
May 2, 2023
|
So let me get this right, it still won't generate the custom type but it will generate a fallback type. That will enable bicep to still build successfully you just won't get full intellisense and whatnot? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
KubernetesResourceTypeProvider.TryGenerateFallbackTypeto always return a generic fallback type.Closes Azure/bicep-extensibility#128.
Microsoft Reviewers: Open in CodeFlow