Fixes to BRM README Generation #10471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ab67be
to
def3d95
Compare
16 tasks
shenglol
previously approved these changes
Apr 19, 2023
|
Thanks for fixing it! Can you update the sample test README files? |
shenglol
approved these changes
Apr 19, 2023
dciborow
commented
Apr 20, 2023
src/Bicep.RegistryModuleTool/ModuleFiles/MainArmTemplateFile.cs
Outdated
Show resolved
Hide resolved
jeskew
approved these changes
Apr 20, 2023
Comment on lines
48
to
49
| ``` No newline at end of file | ||
| ``` |
There was a problem hiding this comment.
I think your editor is automatically injecting a trailing newline, which is causing the reported test failures (e.g., this one).
If you're using VS code, you may need to disable the files.insertFinalNewline setting temporarily.
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Output Alignment
securestring
Minor bug
