Allow all type syntax in output declarations
#10052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeskew
commented
Mar 9, 2023
# Conflicts: # src/Bicep.Core.IntegrationTests/UserDefinedTypeTests.cs # src/Bicep.Core.Samples/Files/TypeDeclarations_LF/main.ir.bicep # src/Bicep.Core.Samples/Files/TypeDeclarations_LF/main.json # src/Bicep.Core.Samples/Files/TypeDeclarations_LF/main.symbolicnames.json # src/Bicep.Core.Samples/Files/TypeDeclarations_LF/main.syntax.bicep
StephenWeatherford
pushed a commit
that referenced
this pull request
Mar 13, 2023
* Replace nerfed output type parser with invocation of param/typeAlias type parser * Bump Azure.Deployments.* dependencies to latest * Update to reconcile with latest Azure.Deployments.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9570.
This PR allows any and all type syntax in
outputstatements, including unions, typed arrays, user-defined objects, references to symbols defined intypestatements, and constraint decorators. The two decorators that are still only permitted onparamstatements are@allowed(in lieu of which a union may be used) and@secure, which has an odd effect when used on an output in ARM. (Outputs with a type ofsecureStringorsecureObjectare allowed, but their values get pruned from the deployment info, so they are not very useful.)Most changes in this PR are baseline updates, as output statements now use the same type loader as
paramandtypestatements.Depends on ARM w09.
Microsoft Reviewers: Open in CodeFlow