Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Deploy with bicep" VS Code task default deployment name uses month twice #14763

Closed
Strandfelt opened this issue Aug 7, 2024 · 0 comments · Fixed by #14764
Closed

"Deploy with bicep" VS Code task default deployment name uses month twice #14763

Strandfelt opened this issue Aug 7, 2024 · 0 comments · Fixed by #14764

Comments

@Strandfelt
Copy link
Contributor

Strandfelt commented Aug 7, 2024

Bicep version
v0.29.47

Describe the bug
The default deployment name for the bicep.deploy task uses month twice for the timestamp instead of minutes.
The following screenshot is taken on 7 August 2024 at 10:11 UTC. The expected suggested name should be main-240807-1011, but the suggested name is main-240807-1008.
image

To Reproduce
In Visual Studio Code, when having a bicep file open, press CTRL + SHIFT + P and select "Deploy bicep file...". Notice the default deployment name pre-filled in the text box that pops up.

Additional context
Code line: https://github.com/Azure/bicep/blob/624835146a8e48677ae1eafe06b20041ed785905/src/vscode-bicep/src/commands/deploy.ts#L111C34-L111C73

The issue in the code is this line:

value: fileName.concat("-", moment.utc().format("YYMMDD-HHMM")),

which should be

value: fileName.concat("-", moment.utc().format("YYMMDD-HHmm")),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant