Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on federated auth by default #36563

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Turn on federated auth by default #36563

merged 1 commit into from
Jul 22, 2024

Conversation

xiangyan99
Copy link
Member

No description provided.

@weshaggard
Copy link
Member

I would also suggest we delete all the places we set this explicitly to true in any tests.yml files where we already set it as that is just noise. https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-python+UseFederatedAuth&type=code

@xiangyan99
Copy link
Member Author

I would also suggest we delete all the places we set this explicitly to true in any tests.yml files where we already set it as that is just noise. https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-python+UseFederatedAuth&type=code

After visiting some tests.yml, I prefer to keep those explicit settings for now to track which services have been migrated. Your ideas?

@weshaggard
Copy link
Member

Can't you count the reverse? i.e. the ones that opt-out like cosmos? If you keep the setting there people will end up copy/pasting it around forever and it really will be a dead property.

@xiangyan99
Copy link
Member Author

We agreed that we will clean all in-tests.yml settings when we move to auxiliary tenant.

@xiangyan99
Copy link
Member Author

Opened #36572 to track the work.

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. They're probably already aware but please let the cosmos folks know that this has been delayed for them.

@xiangyan99 xiangyan99 merged commit b5917d5 into main Jul 22, 2024
62 checks passed
@xiangyan99 xiangyan99 deleted the turn_on_federated_auth branch July 22, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants