Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fine tuning tests #44695

Merged
merged 15 commits into from
Jun 24, 2024
Merged

Add fine tuning tests #44695

merged 15 commits into from
Jun 24, 2024

Conversation

ralph-msft
Copy link
Member

  • Fixes some issues with the FineTuningClient and FileClient that were preventing fine tuning scenarios from working
    • Wrong paths were being used in the generated REST requests
    • Multi-part uploads were not setting the required Content-Type header correctly for each the file part
    • File uploads for fine tuning return HTTP 201 which was treated as an error before
  • Adds more thorough fine tuning model tests, as well as all the required types and clients to be able exercise all parts of the fine tuning model scenario

- Fixes JSON issues due to moving to older JSON version
- Fixes vector store test that was subject to race condition in status
…and cleanup

- Fixed a bug where the path being used for jobs requests was incorrect (missing /jobs/)
- Fixed abug where the job checkpoints was not generating correct requests
- Added some internal only extension methods for FineTuningClient that allow you to delete a job in Azure OpenAI. This differs from how OpenAI works and this seemed liked the easiest way for now allowing testing and a suggestion for a future implementation
- Added some test only models to make working with fine tuning clients easier
- Added more thorough fine tuning testing including some very long running ones
NOTE: This only fixes the issue for Azure OpenAI. A proper fix will require updates to the autogenerated code which will in a later PR
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@ralph-msft ralph-msft merged commit c555b13 into main Jun 24, 2024
17 checks passed
@ralph-msft ralph-msft deleted the ralphe/add_fine_tuning_tests branch June 24, 2024 21:42
tejasm-microsoft pushed a commit to tejasm-microsoft/azure-sdk-for-net that referenced this pull request Jul 22, 2024
- Fixes some issues with the FineTuningClient and FileClient that were preventing fine tuning scenarios from working
  - Wrong paths were being used in the generated REST requests
  - Multi-part uploads were not setting the required Content-Type header correctly for each the file part
  - File uploads for fine tuning return HTTP 201 which was treated as an error before
- Adds more thorough fine tuning model tests, as well as all the required types and clients to be able exercise all parts of the fine tuning model scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants