[AppConfig] Avoid throwing NullReferenceException #31588
Conversation
…eConfigurationSetting.Value is null If the value of a `SecretReferenceConfigurationSetting` is null, accessing this value throws `NullReferenceException`. Seems like an oversight in this line of code.
avanigupta
requested review from
nisha-bhatia,
ShivangiReja,
AlexanderSher and
jsquire
as code owners
ghost
added
the
|
This pull request is protected by Check Enforcer. |
There was a problem hiding this comment.
Changes look good to me!
Thank you so much @avanigupta for your contribution!
|
/check-enforcer override |
|
@ShivangiReja any idea when the new package will be released with this bug fix? |
|
@avanigupta We have a SDK release cycle every month and we release SDKs second week(usually 2nd Tuesday) of every month. I'm planning to release a preview version today/tomorrow. |
|
@ShivangiReja awesome, thanks! |
|
Hi @avanigupta, we have released [email protected] preview version which includes this bug fix. |
@avanigupta We don't have a committed date for GA release and most likely it won't take place until after the new year. The work-around of having a catch block seems simple enough in the meantime. |
|
Hi @ShivangiReja , do we have any plans for a new GA release recently? |
|
@recao We still don't have a committed date for GA release yet. I'll update this thread when we have a date for a GA release. |
If the value of a
SecretReferenceConfigurationSettingis null, accessing this value throwsNullReferenceException. Seems like an oversight in this line of code.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.