feat(iot-dev): Add configurable message expiration check job #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the client would only check for expired messages each time it tried to send a message. Now it will check for expired messages even if the client is idle.
timtay-microsoft
requested review from
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
timtay-microsoft
commented
Nov 3, 2023
| { | ||
| try | ||
| { | ||
| correlationCallbackCleanupThread.start(); |
There was a problem hiding this comment.
We shouldn't start/stop this thread when one device in a multiplexed connection is lost. Only start/stop it when the whole connection is opened/closed
timtay-microsoft
commented
Nov 3, 2023
| * | ||
| * @return true if the packet has been in the queues for longer than the device operation timeout and false otherwise | ||
| */ | ||
| private boolean hasOperationTimedOut(long startTime, String deviceId) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
patilsnr
approved these changes
Nov 6, 2023
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the client would only check for expired messages each time it tried to send a message. Now it will check for expired messages even if the client is idle.