Fix: Bug fix for SasUri generation failure after disconnecting/connec…

[tmahmood-microsoft]

The bug was reproducible when once a file is uploaded to blob storage and after client reconnection, the same process fails with null exception.
The issue was missing open() call to HttpsTransportManager object when the device client is opened after disconnection.

Original GitHub issue: #1662

[timtay-microsoft]

I'd rather see us remove the open/close methods on the HttpsTransportManager since http clients don't have that concept. Similarly, the FileUpload class has nothing to open/close, so we can remove that as well.

With the above, we'd instantiate the FileUpload class once (when the first file upload request is made) and never have to open/close/re-instantiate it again. Thoughts?

[tmahmood-microsoft]

I'd rather see us remove the open/close methods on the HttpsTransportManager since http clients don't have that concept. Similarly, the FileUpload class has nothing to open/close, so we can remove that as well.

With the above, we'd instantiate the FileUpload class once (when the first file upload request is made) and never have to open/close/re-instantiate it again. Thoughts?

This makes more sense, yes. Since the HttpsTransportManager object does not get affected by client reconnection, we dont need to close/open it again.

[tmahmood-microsoft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 4 pipeline(s).

[tmahmood-microsoft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 4 pipeline(s).

[tmahmood-microsoft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 4 pipeline(s).