Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKS Service Target & template #1543

Closed
wants to merge 25 commits into from
Closed

AKS Service Target & template #1543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7304233
Adds AKS bicep infra
wbreza Sep 13, 2022
657a538
Replace env vars in k8s manifests
wbreza Feb 11, 2023
8b06c1b
Bicep updates for AKS
wbreza Feb 15, 2023
ffef765
Add kubectl identity to keyvault access
wbreza Feb 17, 2023
01795f5
Updates aks template readme
wbreza Feb 17, 2023
e21053d
Fixes linting issues
wbreza Feb 17, 2023
80d67fa
Fixes failing unit tests
wbreza Feb 17, 2023
774af74
Install kubectl task
wbreza Feb 17, 2023
e3d3d85
Install kubectl task
wbreza Feb 17, 2023
fb08486
Install kubectl task
wbreza Feb 17, 2023
9c90dba
Updates AKS bicep modules
wbreza Feb 23, 2023
4b17f51
Updates AKS project main bicep
wbreza Feb 23, 2023
e421535
Updates AKS project main bicep
wbreza Feb 23, 2023
408adbd
Updates spelling linter dictionary
wbreza Feb 23, 2023
a5e2afa
Adds support for waiting for deployment & ingress to complete
wbreza Feb 24, 2023
8135f84
Updated bicep based on PR feedback
wbreza Feb 24, 2023
9fe1854
Updates diagram and azure.yaml
wbreza Feb 27, 2023
612b001
Adds TODO for adding resource diagnostics
wbreza Feb 27, 2023
1801621
Minor bicep updates
wbreza Feb 27, 2023
a4be153
Fixes long lines
wbreza Feb 27, 2023
74715bf
Adds happy path deployment test for AKS target
wbreza Feb 28, 2023
28a0692
Adds kubectl unit tests and aks service target tests
wbreza Feb 28, 2023
8bc072e
Fixes cspell lint issues
wbreza Feb 28, 2023
6769bb6
More spelling updates
wbreza Feb 28, 2023
8cd86aa
Adds aks template to templates.json
wbreza Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds TODO for adding resource diagnostics
  • Loading branch information
@wbreza
wbreza committed Feb 28, 2023
commit 612b0013a126a668f8271f291610750ffced1b73
3 changes: 3 additions & 0 deletions templates/common/infra/bicep/core/host/aks-managed-cluster.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ var aksDiagCategories = [
'guard'
]

// TODO: Update diagnostics to be its own module
// Blocking issue: https://github.com/Azure/bicep/issues/622
// Unable to pass in a `resource` scope or unable to use string interpolation in resource types
resource diagnostics 'Microsoft.Insights/diagnosticSettings@2021-05-01-preview' = if (!empty(workspaceId)) {
name: 'aks-diagnostics'
tags: tags
Expand Down
3 changes: 3 additions & 0 deletions templates/common/infra/bicep/core/host/container-registry.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ resource containerRegistry 'Microsoft.ContainerRegistry/registries@2022-02-01-pr
}
}

// TODO: Update diagnostics to be its own module
// Blocking issue: https://github.com/Azure/bicep/issues/622
// Unable to pass in a `resource` scope or unable to use string interpolation in resource types
resource diagnostics 'Microsoft.Insights/diagnosticSettings@2021-05-01-preview' = if (!empty(workspaceId)) {
wbreza marked this conversation as resolved.
Show resolved Hide resolved
name: 'registry-diagnostics'
tags: tags
Expand Down