Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Base64Encoder big bug #560

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

fixed Base64Encoder big bug #560

wants to merge 35 commits into from

Conversation

jacksonjim
Copy link

fixed Base64Encoder big bug

public sealed class NettyBase64Encoder : MessageToMessageEncoder
{
readonly bool breakLines;
readonly Base64Dialect dialect;

    public NettyBase64Encoder() : this(true) { }

    public NettyBase64Encoder(bool breakLines) : this(breakLines, Base64Dialect.STANDARD)
    {
    }

    public NettyBase64Encoder(bool breakLines, Base64Dialect dialect)
    {
        this.breakLines = breakLines;
        this.dialect = dialect;
    }

    public override bool IsSharable => true;

    protected override void Encode(IChannelHandlerContext context, IByteBuffer message, List<object> output)
    {
        output.Add(Base64.Encode(message, message.ReaderIndex, message.ReadableBytes, breakLines, dialect));
    }
}

mikelchai and others added 12 commits November 1, 2018 13:35
extra: give access to executors within executor group
* wip

* fixing async stream->buffer
* Align and add some missing overloads for ByteBuffer
* Add the workaround for case 1 in #436
* Remove Deque.cs from DotNetty.Common
* Fix false positive resource leak report.
* Change some behavior of ResourceLeakDetector
Fix issue parsing manual machine id; fixes #458 - second parameter of `Substring` is 'length' not 'index'
@ghost
Copy link

ghost commented Jun 5, 2021

CLA assistant check
All CLA requirements met.

ailn and others added 17 commits July 16, 2021 18:04
- microsoft.extensions.logging 5.0.0
- microsoft.extensions.configuration 5.0.0
* [0.7.2] Start threads as background in HashedWheelTimer, LoopExecutor, ThreadDeathWatcher

* + code formatting

* [0.7.3] Target net5 and net6 (#2)

target net5 and net6
Adopted TlsHandler for the case when Handshake completion callback is dispatched asynchronously to thread pool
Introduced SingleThreadedEmbededChannel for TlsHandler and SniHandler tests

* + Update DotNetVersion to "6.0.302" in build.ps1
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Fix infinite loop caused by disconnection during TLS handshake, and the memory exploded instantly.
+ Fix infinite loop caused by TlsHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.