Exclude feature flags from loaded settings #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will it be a separated PR to add feature flag option (the example usage in the design doc of JS FM)? |
|
@zhiyuanliang-ms Yes, there will be a separate PR supporting FM. That will not be included in 1.0.0-preview. |
zhiyuanliang-ms
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context information
According to Feature Management design, the loaded key-values should be:
Current behavior
Feature flags will be loaded and treated as JSON objects if customer specifies proper selectors, e.g.
keyFilter: " .appconfig.featureflag/*"Expected behavior
Before FM is supported, the default behavior should be consistent with FM is disabled. We should exclude feature flags.
This will avoid future breaking change.