Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting rule #571

Merged
merged 12 commits into from
Jul 26, 2024
Merged

Add linting rule #571

merged 12 commits into from
Jul 26, 2024

Conversation

zhiyuanliang-ms
Copy link
Contributor

Why this PR?

Add code format check

Visible changes

Linting rules are defined in .editorconfig file.

property is added to the csproj file and then all code format issues will be reported during build process. In the editorconfig file, it sets the severity of IDE0055 and some other formating rules to error.
This will make build fail if the formating rule is not followed.

@juniwang
Copy link

@zhiyuanliang-ms
Copy link
Contributor Author

zhiyuanliang-ms commented Jul 15, 2024

what's the purpose of this file: https://github.com/Azure/AppConfiguration-DotnetProvider/blob/main/AzureAppConfigurationRules.ruleset ?

@juniwang This file is used for enforce CA2007 check. #410

Code analysis is a big topic. It includes two aspects: code quality and code style.

image

CA2007 belongs to code quality check.

Even for code style, there are 4 aspects as shown in the screenshot below.

image

In this PR, we only focus on the formatting rules.

@juniwang
Copy link

what's the purpose of this file: https://github.com/Azure/AppConfiguration-DotnetProvider/blob/main/AzureAppConfigurationRules.ruleset ?

@juniwang This file is used for enforce CA2007 check. #410

Code analysis is a big topic. It includes two aspects: code quality and code style.

image

CA2007 belongs to code quality check.

Even for code style, there are 4 aspects as shown in the screenshot below.

image

In this PR, we only focus on the formatting rules.

OK,

@juniwang juniwang closed this Jul 17, 2024
@juniwang juniwang reopened this Jul 17, 2024
@zhiyuanliang-ms zhiyuanliang-ms merged commit 08e5930 into main Jul 26, 2024
3 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/add-linting-rule branch July 26, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants