Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct the URI's for the Windows KBs in release notes #1811

Merged
merged 2 commits into from
May 12, 2022

Conversation

AbelHu
Copy link
Member

@AbelHu AbelHu commented May 12, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
Correct the URI's for the Windows KBs in release notes

Which issue(s) this PR fixes:

Fixes #
Azure/AKS#2950

Requirements:

Special notes for your reviewer:

Release note:

none

@AbelHu AbelHu temporarily deployed to test May 12, 2022 00:15 Inactive
@AbelHu
Copy link
Member Author

AbelHu commented May 12, 2022

cc @jsturtevant @marosset Since the code in AgentBaker was copied from aks-engine, aks-engine should have the same issue.
https://github.com/Azure/aks-engine/blob/47c439d1e8891a1cc63ced39332418f1506e6a41/vhd/packer/write-release-notes-windows.ps1#L60

Copy link
Contributor

@thecloudtaylor thecloudtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AbelHu AbelHu enabled auto-merge (squash) May 12, 2022 01:17
@AbelHu AbelHu temporarily deployed to test May 12, 2022 01:17 Inactive
@AbelHu AbelHu merged commit a416647 into master May 12, 2022
@AbelHu AbelHu deleted the abelch/update-win-release-notes-kb-uri branch May 12, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants