Switch to Guzzle 6 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guzzle in version 6
Add package name.
Back to previous composer but with guzzle 6
|
Or maybe only add in the composer.json that we can use the version 6.0 ? Like this : "guzzlehttp/guzzle": "^6.0|^7.0", |
hywak
requested changes
Nov 13, 2020
|
Hey @BastienU, Thank you for your pull request. I've reviewed your changes and tested locally code on Guzzle 6.5.5 installed accordingly to your suggestion ( |
Change "guzzlehttp/guzzle" allowef version in composer.json
|
Changes done :-) |
hywak
approved these changes
Nov 13, 2020
|
@BastienU your changes are visible since version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Your package seems to be perfect... but you are using Guzzle 7. However, Guzzle 7 is not necessary for this package to be fully functionnal, Guzzle 6 is enough. Moreover, when you are using Laravel 7, using Guzzle 7 is blocking the installation.
So, can you use Guzzle 6 in this package to make it run for everyone ? :-)
Thanks a lot !