-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added new apple public identifier key
- Loading branch information
Marcin Szulc
committed
Jan 25, 2022
1 parent
0a629b2
commit 1d3b60a
Showing
2 changed files
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d3b60a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can anyone explain why these new keys keep appearing and what can be done to have this work automatically. I'm having to rely on catching an error log to see its broken for a client, and then fixing and deploying afterwards - which isn't great. Do Apple give any warnings of new keys being used?
1d3b60a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea whether Apple is informing about updating the keys. However, I'm trying to figure out how to get rid of that exception, because we are facing the same problem as you. Initially I thought that keys won't change often. I was wrong :|
1d3b60a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is released, sorry for inconvenience.
1d3b60a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see you have a TODO item already to fetch the algorithms dynamically..... the code already does this 🤔.
So you don't really need to maintain your own internal list of supported key IDs in an enum, just lookup the key in the list downloaded. 🤷♂️ I think you can just delete the enum and the checks around it, and inside JsonWebKeySetCollection::getByCryptographicAlgorithm just check the keys downloaded already.