Include hidden users in stats #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
decabeza
approved these changes
Apr 5, 2019
This way we can share the `participants` method between budget and poll stats.
If users participated and were hidden after participating, we should still count them in the participants stats. In the tests, we set users' `hidden_at` attribute before they vote. Although in real life they would vote first and then they would be hidden, I've written the tests like this for the sake of simplicity.
javierm
force-pushed
the
include_hidden_users_in_stats
branch
from
fe4bd86
to
c3e9b27
Compare
microweb10
approved these changes
Apr 8, 2019
|
Travis failure was related to issue consul#3325 and not to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Include hidden users in stats. Sometimes users participate in a process and a while after that they are hidden. We were modifying the stats when that happened, not counting the users who were hidden anymore.
Does this PR need a Backport to CONSUL?
Yes, backport when we backport everything related to stats.