Display all polls for current booth #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 13, 2019
voodoorai2000
force-pushed
the
polls_unanswerable
branch
from
13ca1ef
to
bea1d99
Compare
houndci-bot
reviewed
Mar 13, 2019
decabeza
approved these changes
Mar 13, 2019
decabeza
approved these changes
Mar 13, 2019
microweb10
approved these changes
Mar 13, 2019
Polls that were not votable by a user were not being displayed in the officing interface. Creating a confusing situation for officers. With this commit polls that are not votable by a user will be displayed, with the corresponding message explaining that that poll can only be voted by residents of a certain geozone.
Budget polls behave slightly differently to non-budget polls. In budget polls we use Budget::Ballot::Lines to verify if a user has already voted online. In non-budget polls we use Poll::Voter to verify this. In this commit we are adding an extra check to make sure that the correct message is displayed if the user has already voted online for a budget poll[1] [1] https://github.com/AyuntamientoMadrid/consul/blob/master/spec/features/budget_polls/voter_spec.rb#L122
voodoorai2000
force-pushed
the
polls_unanswerable
branch
from
84473c5
to
2b1c486
Compare
javierm
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Polls that were not votable by a user were not being displayed in the officing interface. Creating a confusing situation for officers.
Objectives
Polls that are not votable by a user should be displayed and a corresponding message displayed explaining that a poll can only be voted by residents of a certain geozone.
Visual Changes
Does this PR need a Backport to CONSUL?
Yes, officers should see polls that are not votable by a user in CONSUL too.