[Upstream] I18n language names #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There where two issues with the current implementation: - There was a possible duplication between looking up the language name in key "locale" and in key "i18n.language.name" - The "default" option was not being picked up, as the fallback always returned the default locale's translation, "English" With this implementation there is only a single place to put the language name: i18n.language.name. I think this place is easier to find and understand for Crowdin translators than a "locale" key hidden in general.yml If the translation is not found we display the language key, instead of English, which makes more sense to me too 😌 Solution based on recent comments[1] on a related I18n issue [1] ruby-i18n/i18n#365 (comment)
Add i18n.yml to i18n task's available translation files
`I18n.available_locales=` does a little magic[1] and was causing some flakieness along the way, as the `:wl` locale persisted in future specs Thanks for the heads up @javierm 👌 [1] https://www.rubydoc.info/github/svenfuchs/i18n/I18n%2FConfig:available_locales=
houndci-bot
reviewed
Oct 10, 2018
spec/helpers/locales_helper_spec.rb
Outdated
| end | ||
|
|
||
| end | ||
| end |
There was a problem hiding this comment.
Layout/TrailingBlankLines: Final newline missing. (https://github.com/bbatsov/ruby-style-guide#newline-eof)
voodoorai2000
changed the title
voodoorai2000
force-pushed
the
i18n-language-names
branch
from
e9e2313
to
6801a56
Compare
decabeza
approved these changes
Oct 10, 2018
javierm
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
consuldemocracy#2949
Objectives
Visual Changes
Languages with and without translations
