Flaky residence assigned officers error

[vicentemendozam]

Where

• Related Issue: Flaky spec: Residence Assigned officers Error on verify Unable to find visible button "Validate document" #1211

What

• Hunt the flaky that appears in /spec/features/officing/residence_spec.rb:70:
• Specific error in test:

     Failure/Error: click_button 'Validate document'
     Capybara::ElementNotFound:
       Unable to find visible button "Validate document"
     # ./spec/features/officing/residence_spec.rb:70:in `block (3 levels) in <top (required)>'

How

• Explanation:

There are two buttons (one link and one button) with the same name. This only happen with the translation for the buttons match. For example in Spanish it is different translations.

• Flaky Explanation:

The fact it is a flaky test is because capybara calls them visually with click_link and click_button and both have the same name.

• Fix Explantion:

Include a within in each call to the button/link to specify exactly where the button/link we need to use is located.

      within("#new_residence") do
        click_button "Validate document"
      end

-Backport PR:

Waiting for revision to create it.

Screenshots

Test

• No test added

Deployment

• N/A

Warnings

• click_on , click_link , click_button It can be ambiguous and can give an error. If it is called in the same way, the place to search should be specified.
• In the same document there are more tests with calls to these methods. After the revision I can match the other tests.